Fix compile error when target is wasm and multipart feature is enabled. #1296
+15
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close #1295.
Without this fix master (and v0.11.4) fails to compile with this command:
cargo build --target wasm32-unknown-unknown --features multipart
@seanmonstar Your initial suggestion was to remove #[derive(Clone)] from enum Inner, and change clone() method to try_clone() that matches on the inner type.
But after some research I found out that clone could be implemented for both Inner::Bytes and Inner::Multipart with minimal changes. (I added several #[derive(Clone)] attributes)
What do you think about this change? I am open to implementing your initial suggestion.
I am open to feedback and I will address comments asap.