This repository has been archived by the owner on Mar 5, 2023. It is now read-only.
Edit the addresses of DTD files used for checkstyle #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are currently using the DTD files from `http://checkstyle.sourceforge.net/` and `http://puppycrawl.com/` in our config file of checkstyle. However, due to security reason, checkstyle decided to remove DTDs from above websites and ask users to use the DTD files from `https://checkstyle.org/`[1]. Let's update the addresses of DTD files correspondingly. Meanwhile, update the version of suppression DTD file to 1.2 because it is the version suggested from checkstyle. [2] [1] checkstyle/checkstyle#6478 [2] https://checkstyle.org/config_filters.html#SuppressionFilter_Examples
|
Click here to submit a new iteration when this PR is ready for review. See this repository's contribution guide for more information. |
v1@fzdy1914 submitted v1 for review. Checkout this PR version locallygit fetch https://github.com/se-edu/addressbook-level4.git refs/pr/984/1/head:BRANCHNAMEwhere |
pyokagan
approved these changes
Mar 7, 2019
damithc
approved these changes
Mar 8, 2019
lycjackie
added a commit
to CS2113-AY1819S2-T09-1/main
that referenced
this pull request
Mar 18, 2019
#86) Upstream se-edu/addressbook-level4@e09826e updated the addresses of Checkstyle DTD files for security reason. Let's follow and merge the changes from se-edu#984 into master branch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using the DTD files from
http://checkstyle.sourceforge.net/and
http://puppycrawl.com/in our config file of checkstyle.However, due to security reason, checkstyle decided to remove DTDs from
above websites and ask users to use the DTD files from
https://checkstyle.org/[1].Let's update the addresses of DTD files correspondingly.
Meanwhile, update the version of suppression DTD file to 1.2 because it is
the version suggested from checkstyle. [2]
[1] checkstyle/checkstyle#6478
[2] https://checkstyle.org/config_filters.html#SuppressionFilter_Examples