Add flake8-quotes #274
Merged
Add flake8-quotes #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.6.0-dev #274 +/- ##
===============================================
+ Coverage 0 89.90% +89.90%
===============================================
Files 0 9 +9
Lines 0 773 +773
===============================================
+ Hits 0 695 +695
- Misses 0 78 +78
Continue to review full report at Codecov.
|
csala
requested review from
a team,
fealho and
amontanez24
and removed request for
a team,
csala and
amontanez24
fealho
approved these changes
Oct 4, 2021
setup.py
Outdated
| @@ -52,6 +52,7 @@ | |||
| 'flake8-sfs>=0.0.3,<0.1', | |||
| 'isort>=4.3.4,<5', | |||
| 'pylint>=2.5.3,<3', | |||
| 'flake8-quotes>=3.3.0,<3.4', | |||
There was a problem hiding this comment.
@pvk-developer maybe we should cap it at <4? It seems like they will release the 3.4.0 soon.
amontanez24
approved these changes
Oct 5, 2021
csala
pushed a commit
that referenced
this pull request
Oct 13, 2021
* Add flake8-quotes and adapt the code * Remove double quotes * Update cap version
amontanez24
pushed a commit
that referenced
this pull request
Oct 26, 2021
* Add flake8-quotes and adapt the code * Remove double quotes * Update cap version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #248 added
flake8-quotesaddon and adapted our code to follow this style check.