Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump serde from 1.0.123 to 1.0.124 #49

Closed
wants to merge 1 commit into from
Closed

chore(deps): bump serde from 1.0.123 to 1.0.124 #49

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 16, 2021 •
edited

Bumps serde from 1.0.123 to 1.0.124.

Release notes

Sourced from serde's releases.

v1.0.124

  • Fix possible panic deserializing invalid data as SystemTime (#1997, thanks @​cyang1)
Commits
  • 5a8dcac Release 1.0.124
  • 697b082 Touch up PR 1997
  • d91075c Merge pull request #1997 from cyang1/systemtime-panics
  • 4118cec Prevent various panics when deserializing malformed SystemTime
  • c261015 Ignore incorrect suggestion from manual_map lint
  • 6b5e5a8 Ignore let_underscore_drop pedantic clippy lint
  • bc6b2b1 Make json5 description capitalization consistent with other links
  • beb21cb Ignore new missing_panics_doc pedantic clippy lint
  • 7cfebbc Merge pull request #1974 from Mingun/new-internally-tagged-tests
  • b60c03e Extend test_internally_tagged_newtype_variant_containing_unit_struct to cover...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
chore(deps): bump serde from 1.0.123 to 1.0.124
561c3bc 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.123 to 1.0.124.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.123...v1.0.124)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 16, 2021
@pull-request-quantifier-deprecated
Copy link

This PR has 10 quantified lines of changes. In general, a change size of 50 to 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +5 -5
Percentile : 4%

Total files changed: 2

Change summary by file extension:
.lock : +4 -4
.toml : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #49 (561c3bc) into master (a9b53b0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   40.82%   40.82%           
=======================================
  Files          11       11           
  Lines         556      556           
=======================================
  Hits          227      227           
  Misses        329      329

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b53b0...561c3bc. Read the comment docs.

Repository owner deleted a comment from pull-checklist bot Mar 16, 2021
@sdttttt sdttttt self-requested a review March 16, 2021 07:03
@sdttttt
Copy link
Owner

sdttttt commented Mar 16, 2021 via email

@dependabot dependabot bot closed this Mar 16, 2021
@dependabot dependabot bot deleted the dependabot/cargo/serde-1.0.124 branch March 16, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdttttt sdttttt Awaiting requested review from sdttttt

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sdttttt