New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API to check if a GIF is animated #114
Conversation
What if it's animated but has one frame? Or two frames that are equal? |
This is a best effort approach, which tries to determine if the user would perceive it as animated (thus, if it has one frame and it is "animated", then it is no problem). I did not try to solve the other problem because any solution I came up required full parsing of the GIF image and defeated the philosophy of the library (do things quickly with as little data as possible). |
As user I would probably be ok if it was just giving the number of frames. |
It would be better to call the api "animated?" and return a boolean value.
|
6c83d28
to
c59b45e
Compare
Hi, looking good. Fix the inline documentation to match? |
Hi @sdsykes! I've made the necessary changes to match documentation. Can you have another look? 😊 |
Thanks I think this is ok, I will final check and merge/release soon. |
No description provided.