ISO8601 Interval Separator #611
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 30, 2022 14:40
An interval is split on either a `/` or a `--`. According to the Wikipedia entry on ISO8601 Intervals: >Section 3.2.6 of ISO 8601-1:2019 notes that "A solidus may be replaced >by a double hyphen ["--"] by mutual agreement of the communicating >partners", and previous versions used notations like "2000--2002".[39] >Use of a double hyphen instead of a solidus allows inclusion in computer >filenames;[40] in common operating systems, a solidus is a reserved >character and is not allowed in a filename.
Tests that parse the compact ISO8601 datetime format are added along with copies of the same tests using the `--` instead of the `/` separator. This ensures parity between parsing regardless of separator. However, no test has been added if _both_ `--` and `/` appear in the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
According to the Wikipedia entry for the ISO8601 format (I do not have access to the official specification):
A
--can be used as an alternative to/to separate the begin and end components of an interval. I would like to use the--separator for my application where the/would cause issues, specifically in a URL and in a filename as mentioned in the Wikipedia article.I saw that this excellent package is able to parse ISO8601 intervals, but only if the
/is used. I was hoping to provide this PR to parse an interval if either the/or the--is present.I have added additional tests and documentation that also include parsing intervals without colons,
:, or dashes,-, because it wasn't clear to me from the tests or documentation if the "compact" ISO8601 datetime strings could be used with intervals. I would like to use the "compact" strings for similar reasons of using them for filenames and colons, specifically, are special characters on some systems.