Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/alternator: un-xfail a test which passes on modern Python #12038

Closed
wants to merge 1 commit into from
Closed

test/alternator: un-xfail a test which passes on modern Python #12038

wants to merge 1 commit into from

Commits on Nov 20, 2022

  1. test/alternator: un-xfail a test which passes on modern Python 

    We had an xfailing test that reproduced a case where Alternator tried
to report an error when the request was too long, but the boto library
didn't see this error and threw a "Broken Pipe" error instead. It turns
out that this wasn't a Scylla bug but rather a bug in urllib3, which
overzealously reported a "Broken Pipe" instead of trying to read the
server's response. It turns out this issue was already fixed in
   urllib3/urllib3#1524

and now, on modern installations, the test that used to fail now passes
and reports "XPASS".

So in this patch we remove the "xfail" tag, and skip the test if
running an old version of urllib3.

Fixes scylladb#8195
    @nyh
    nyh committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    c3e70b4 View commit details
    Browse the repository at this point in the history