util: Add support for backoff dependency version 4.1.3 #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YvanDaSilva could you please remind why you needed this branch ? |
|
@karol-kokoszka backoff 4.1.3 contains an API breaking change. The API is now returning a go error instead of a customer backoff one (Permanent.Error). This branch is what the siren / bo are actually targeting ( github.com/scylladb/scylla-manager/v3 v3.0.0-20220929135250-b593dfbd3239 ) If you merge to master, we will be able to target your latest release instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the "backoff" dependency.
Version 4.1.3 brings fixes for context cancelling.
cenkalti/backoff@1357787
However, this "patch" version change does bring an API breakage as .Permanent is now returning a go std error instead of a Permanent.Error from the backoff module.