Use latest phpstan, drop composer-bin-plugin #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Sep 9, 2023
| @@ -37,7 +37,7 @@ | |||
| "ext-iconv": "Can be used as fallback when ext-mbstring is not available" | |||
| }, | |||
| "require-dev": { | |||
| "bamarni/composer-bin-plugin": "^1.4", | |||
There was a problem hiding this comment.
newer phpstan versions no longer define external dependencies. we don't need the composer bin plugin anymore
There was a problem hiding this comment.
The main issue is that the 1.x branch supports PHP versions that are not supported by phpstan.
There was a problem hiding this comment.
ohh wow.. PHP5 is kind of old, didn't realize. thanks for the hint.
is it fine for the master branch?
There was a problem hiding this comment.
For now, I'd rather keep the same setup in both branches. It makes it simpler to merge up.
Once the 2.0 rewrite is over and I can stop maintaining 1.x, I will reconsider
|
failling test looks unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.