Make AST nodes castable to string #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The evaluator casts the AST to string to provide recommendations in some deprecation warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially omitted that string representation when porting the AST, thinking it was only about providing a better debugging experience. But I was wrong. The evaluator casts the AST to string to provide recommendations in some deprecation warnings.
As part of that porting work, I went over the string representation of all AST nodes in dart-sass, which made me discover a few issues in their logic (the string representation is not covered by the testsuite, except for cases used by some deprecation warnings in sass-spec, but that's mostly expression nodes). The fixes submitted in sass/dart-sass#1682 are already included in this PR.