Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trace): fix memory trace size #497

Merged
merged 4 commits into from Sep 1, 2023
Merged

fix(trace): fix memory trace size #497

merged 4 commits into from Sep 1, 2023

Conversation

lispc
Copy link

@lispc lispc commented Aug 31, 2023

1. Purpose or design rationale of this PR

pick ethereum#24867 from upstream.
this pr fixes memory size in trace

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@lispc lispc linked an issue Aug 31, 2023 that may be closed by this pull request
@lispc lispc changed the title Fix(trace): fix memory trace size fix(trace): fix memory trace size Aug 31, 2023
core/vm/interpreter.go Show resolved Hide resolved
@HAOYUatHZ
Copy link
Member

if operation.memorySize != nil is also inside if operation.dynamicGas != nil in https://github.com/holiman/go-ethereum/blob/97f308a98f9f2f557a0815665f6497eac8f469fd/core/vm/interpreter.go#L207-L217

should we sync it?

@lispc
Copy link
Author

lispc commented Sep 1, 2023

if operation.memorySize != nil is also inside if operation.dynamicGas != nil in https://github.com/holiman/go-ethereum/blob/97f308a98f9f2f557a0815665f6497eac8f469fd/core/vm/interpreter.go#L207-L217

should we sync it?

seems a standalone performance optimization pr. ethereum#24048.

So at least in this pr we will not pick that

@HAOYUatHZ HAOYUatHZ merged commit c60fa3a into develop Sep 1, 2023
5 checks passed
@HAOYUatHZ HAOYUatHZ deleted the fix/memory-trace branch September 1, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backlog: updates needed for next circuit release
4 participants