Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade CORS library to v1.7.0 #30

Merged
merged 1 commit into from Nov 18, 2021
Merged

Conversation

Neurostep
Copy link
Contributor

@Neurostep Neurostep commented Nov 18, 2021

Description

We use cors library to set up CORS handlers for our HTTP servers. In v1.8.0 introduced backwards-incompatible changes that potentially might break the clients. Thus, it might affect the existing behavior of the web-analytics-ingestion which explicitly checks for 200 status codes returned for pre-flight requests.

The spec doesn't tell us what HTTP status to use for prefight responses, but some clients indeed might rely on the 200 status code returned.

In order to avoid any potential problems with CORS, as a short-term solution, we downgrade the cors library to version v1.7.0. As a long-term solution, we raised a PR to the original cors library to provide a way to specify response code for pre-flight requests.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links

@Neurostep Neurostep requested a review from a team as a code owner November 18, 2021 14:07
Copy link
Member

@fotos fotos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM 🚀

I see that the upstream PR got approved / merged already. 👏 👏 👏

@Neurostep Neurostep merged commit e7628b9 into main Nov 18, 2021
@Neurostep Neurostep deleted the maksimt/downgrade-cors-lib branch November 18, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants