Add Jest-specific linting rules #5057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding this caught a couple of important things: - The sound integration tests have a `.only` in them - The project-saver-hoc tests had two tests with the same description, causing possible confusion if that test broke
rschamp
commented
Aug 1, 2019
| @@ -1,4 +1,4 @@ | |||
| jasmine.DEFAULT_TIMEOUT_INTERVAL = 30000; // eslint-disable-line no-undef | |||
| jest.setTimeout(30000); // eslint-disable-line no-undef | |||
There was a problem hiding this comment.
Confirmed that these are equivalent via https://jestjs.io/docs/en/jest-object.html#jestsettimeouttimeout and jestjs/jest#652
rschamp
commented
Aug 1, 2019
| @@ -55,7 +55,7 @@ describe('Slider Prompt Container', () => { | |||
| const componentProps = wrapper.find(SliderPromptComponent).props(); | |||
| componentProps.onChangeMin({target: {value: '1.0'}}); | |||
| componentProps.onOk(); | |||
| expect(onOk).toBeCalledWith(1, 100, false); | |||
| expect(onOk).toHaveBeenCalledWith(1, 100, false); | |||
There was a problem hiding this comment.
Would not be opposed to disabling this rule if we think it's annoying, it's just part of the recommended set. These changes were made just by using --fix, so pretty easy to deal with.
rschamp
commented
Aug 1, 2019
| @@ -423,7 +423,7 @@ describe('projectSaverHOC', () => { | |||
| expect(mockedOnRemixing).toHaveBeenCalledWith(true); | |||
| }); | |||
|
|
|||
| test('when starting to remix, onRemixing should be called with param true', () => { | |||
| test('when starting to remix, onRemixing should be called with param false', () => { | |||
There was a problem hiding this comment.
The test above this one has the same name, so the linter caught this copy-paste error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up from #5049, so that kind of mistake will cause linting to fail.
Adding this caught a couple of important things:
.onlyin them on the version of the code I had at the time