Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore invalid supplied MIME types #18

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Dec 29, 2023

Based on a real-world scenario found as part of scrapy/scrapy#5204 (comment).

According to the standard, step 5 in https://mimesniff.spec.whatwg.org/#interpreting-the-resource-metadata:

If supplied-type is not a MIME type, the supplied MIME type is undefined.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (062c229) 100.00% compared to head (6054230) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          352       367   +15     
=========================================
+ Hits           352       367   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gallaecio Gallaecio merged commit 0cc6560 into scrapy:main Dec 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants