Fix the offsite middleware missing some requests #6358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
changed the title
This was referenced May 14, 2024
|
Hey @Gallaecio! Sorry for a late comment. Not sure if that's very importnant, but I wonder if we should keep both middlewares, and have both enabled, because spider middleware allows all these requests to skip the scheduler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrapy was enforcing Spider.allowed_domains only for requests coming from spider callbacks, but not for:
Spider.start_requests.RedirectMiddlewareandMetaRefreshMiddleware), or custom middlewares yielding new requests for different domains.crawler.engine.downloadmethod, including:RobotsTxtMiddlewarerequests for therobots.txtfile of a domain.This is now solved by replacing the offsite spider middleware with a downloader middleware.
Fixes #1042, closes #2241.