Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full typing for scrapy/spiders. #6356

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented May 12, 2024

No description provided.

Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 95.87629% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 89.69%. Comparing base (180bc9b) to head (e0bec78).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6356      +/-   ##
==========================================
+ Coverage   85.00%   89.69%   +4.69%     
==========================================
  Files         161      161              
  Lines       11962    11974      +12     
  Branches     1872     1699     -173     
==========================================
+ Hits        10168    10740     +572     
+ Misses       1512      927     -585     
- Partials      282      307      +25     
Files Coverage Δ
scrapy/spiders/__init__.py 100.00% <100.00%> (ø)
scrapy/spiders/crawl.py 96.87% <100.00%> (+0.28%) ⬆️
scrapy/spiders/init.py 100.00% <100.00%> (ø)
scrapy/spiders/sitemap.py 85.36% <100.00%> (+0.18%) ⬆️
scrapy/utils/sitemap.py 96.15% <100.00%> (ø)
scrapy/spiders/feed.py 69.56% <83.33%> (-3.46%) ⬇️

... and 32 files with indirect coverage changes

@Gallaecio Gallaecio merged commit b8e333c into scrapy:master May 13, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants