Use ParamSpec for callables. #6353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wRAR
commented
May 11, 2024
Comment on lines
+86
to
+110
| @overload | ||
| def mustbe_deferred( | ||
| f: Callable[_P, Deferred[_T]], *args: _P.args, **kw: _P.kwargs | ||
| ) -> Deferred[_T]: ... | ||
|
|
||
|
|
||
| @overload | ||
| def mustbe_deferred( | ||
| f: Callable[_P, Coroutine[Deferred[Any], Any, _T]], | ||
| *args: _P.args, | ||
| **kw: _P.kwargs, | ||
| ) -> Deferred[_T]: ... | ||
|
|
||
|
|
||
| @overload | ||
| def mustbe_deferred( | ||
| f: Callable[_P, _T], *args: _P.args, **kw: _P.kwargs | ||
| ) -> Deferred[_T]: ... | ||
|
|
||
|
|
||
| def mustbe_deferred( | ||
| f: Callable[_P, Union[Deferred[_T], Coroutine[Deferred[Any], Any, _T], _T]], | ||
| *args: _P.args, | ||
| **kw: _P.kwargs, | ||
| ) -> Deferred[_T]: |
There was a problem hiding this comment.
This is copied from maybeDeferred
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6353 +/- ##
==========================================
- Coverage 85.00% 84.86% -0.14%
==========================================
Files 161 161
Lines 11962 11996 +34
Branches 1872 1877 +5
==========================================
+ Hits 10168 10181 +13
- Misses 1512 1529 +17
- Partials 282 286 +4
|
Gallaecio
approved these changes
May 13, 2024
And in all cases readability improved, in my opinion. Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also changed most of
addCallbacks()toaddCallback()/addErrback(), as the official docs say the former has worse type hints (the ones I kept need to stay for various reasons).I plan to add parameter specifications to more generics as separate PRs.