Closes #6340. Deprecate the spider argument to Downloader._get_slot_key() #6352
Conversation
docs/news.rst
Outdated
| @@ -1262,6 +1262,9 @@ Deprecations | |||
| - :func:`scrapy.utils.response.response_httprepr` is now deprecated. | |||
| (:issue:`4972`) | |||
|
|
|||
| - :func:`scrapy.core.downloader.Downloader._get_slot_key` is now deprecated. Consider using its corresponding public method instead. | |||
There was a problem hiding this comment.
Can you please wrap the line to 80 chars?
scrapy/core/downloader/__init__.py
Outdated
| @@ -153,6 +155,14 @@ def _get_slot_key(self, request: Request, spider: Optional[Spider]) -> str: | |||
|
|
|||
| return key | |||
|
|
|||
| def _get_slot_key(self, request: Request, spider: Optional[Spider]) -> str: | |||
| warnings.warn( | |||
| "Use of this protected method is deprecated. Consider using its corresponding public method instead.", | |||
There was a problem hiding this comment.
I'd mention the new name explicitly.
kumar-sanchay
force-pushed
the
deprecate_method
branch
from
b7fa711
to
23ab1e5
Compare
|
@wRAR done with the changes you suggested |
docs/news.rst
Outdated
| - :func:`scrapy.core.downloader.Downloader._get_slot_key` is now deprecated. | ||
| Consider using its corresponding public method get_slot_key() instead. | ||
| (:issue:`6340`) | ||
|
|
There was a problem hiding this comment.
This is a section for an old release. To cover this new change, you should either add it at the very beginning of the file, in a new section for an unreleased version, or do nothing, and hope we don’t forget to cover this when the build the release notes. The first approach is better, but the second approach is the usual and fine as well.
There was a problem hiding this comment.
Ahh ! I see, thank you for pointing this out
kumar-sanchay
force-pushed
the
deprecate_method
branch
from
23ab1e5
to
20cb4ae
Compare
docs/news.rst
Outdated
|
|
||
| .. _release-2.11.2: | ||
|
|
||
| Scrapy 2.11.2 |
There was a problem hiding this comment.
I've not added release date here assuming this will be taken care during release
Do you believe testing would be beneficial in this case, considering that the deprecated method internally returning new public method ? |
You are right that here it would not add much, I’m OK with not adding it. |
|
Thank you! |
Fix #6340