Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full typing for scrapy/extensions, part 3. #6325

Merged
merged 4 commits into from Apr 29, 2024

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Apr 28, 2024

No description provided.

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 97.17514% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 88.87%. Comparing base (1d11ea3) to head (f5b65de).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6325      +/-   ##
==========================================
+ Coverage   83.92%   88.87%   +4.94%     
==========================================
  Files         161      161              
  Lines       11972    12003      +31     
  Branches     1865     1930      +65     
==========================================
+ Hits        10048    10668     +620     
+ Misses       1588      982     -606     
- Partials      336      353      +17     
Files Coverage Δ
scrapy/extensions/postprocessing.py 98.41% <100.00%> (ø)
scrapy/utils/iterators.py 93.33% <ø> (+1.36%) ⬆️
scrapy/extensions/httpcache.py 94.84% <97.01%> (-0.64%) ⬇️
scrapy/extensions/feedexport.py 94.53% <97.24%> (+11.20%) ⬆️

... and 25 files with indirect coverage changes

@Gallaecio Gallaecio merged commit 57acad3 into scrapy:master Apr 29, 2024
26 checks passed
@wRAR wRAR deleted the typing-extensions-3 branch May 6, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants