Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use defusedxml.xmlrpc #6251

Merged
merged 3 commits into from Feb 28, 2024
Merged

Use defusedxml.xmlrpc #6251

merged 3 commits into from Feb 28, 2024

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Feb 27, 2024

Fix #6250

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #6251 (008ebb6) into master (2d46b4a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6251   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files         161      161           
  Lines       11790    11792    +2     
  Branches     1913     1913           
=======================================
+ Hits        10482    10484    +2     
  Misses        980      980           
  Partials      328      328           
Files Coverage Δ
scrapy/http/request/rpc.py 100.00% <100.00%> (ø)

@Gallaecio
Copy link
Member

@wRAR @Laerte Any idea why bandit is passing even though B411 is not in https://github.com/scrapy/scrapy/blob/master/.bandit.yml ?

@wRAR
Copy link
Member

wRAR commented Feb 27, 2024

B411 is only emitted by a newer version, I haven't published a PR that bumps it yet.

scrapy/http/request/rpc.py Outdated Show resolved Hide resolved
@Laerte Laerte requested a review from wRAR February 27, 2024 20:52
scrapy/http/request/rpc.py Outdated Show resolved Hide resolved
@Laerte Laerte requested a review from wRAR February 27, 2024 21:13
Copy link
Member

@wRAR wRAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wRAR wRAR merged commit 415c474 into scrapy:master Feb 28, 2024
26 checks passed
@wRAR
Copy link
Member

wRAR commented Feb 28, 2024

Note that PyCQA/bandit#1082 applies here, so we will still need to silence the error until the fix detection is added/fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use defusedxml.xmlrpc
3 participants