Add component getters to crawler #6181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6181 +/- ##
==========================================
+ Coverage 88.61% 88.66% +0.04%
==========================================
Files 159 160 +1
Lines 11607 11638 +31
Branches 1891 1897 +6
==========================================
+ Hits 10286 10319 +33
Misses 994 994
+ Partials 327 325 -2
|
|
Will it be helpful for #6136? |
|
No idea, but I suspect not 😞 |
|
Ah yeah, it covers different things, but the approach could be useful there. |
wRAR
approved these changes
Dec 19, 2023
kmike
reviewed
Dec 20, 2023
wRAR
approved these changes
Dec 21, 2023
BurnzZ
approved these changes
Dec 22, 2023
kmike
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @BurnzZ.