Fix for issue 6136 #6172
Closed
Fix for issue 6136 #6172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempted build_from_crawler
|
#6136 is not about stats, it's about a general solution to this that doesn't invove changing all the code. And you didn't even review your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue #6136.
Added a method for the crawler class called retrieve_stats() that performs the necessary assertion to check if the stat field is not none and then returns crawler.stats. This removes the need to add an assert statement every time crawler.stats needs to be accessed. Additionally, most instances of crawler.stats has been replaced with crawler.retrieve_stats() so that the assertion is performed automatically.