Incompatible with pytest 5.4 and 5.4.1

[altendky]

No description provided.

[codecov]

Codecov Report

Merging #4588 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4588      +/-   ##
==========================================
+ Coverage   84.54%   84.57%   +0.03%     
==========================================
  Files         164      164              
  Lines        9931     9931              
  Branches     1477     1477              
==========================================
+ Hits         8396     8399       +3     
+ Misses       1267     1266       -1     
+ Partials      268      266       -2     

Impacted Files	Coverage Δ
scrapy/core/downloader/__init__.py	90.97% <0.00%> (+1.50%)	⬆️
scrapy/utils/trackref.py	85.71% <0.00%> (+2.85%)	⬆️

[altendky]

This is following up on pytest-dev/pytest-twisted#93.

[elacuesta]

Thanks for the work on pytest-dev/pytest-twisted#93 🚀
Should we consider pinning pytest>=5.4.2 instead?

[altendky]

I did this because before it was just pytest so I was only banning the actually failing versions instead of introducing a minimum. If this were a new feature rather than a temporary breakage in a couple versions then >= would make sense to me.

[Gallaecio]

+1 since there’s no reason to change the minimum.

However, I would suggest including an in-line comment for reference, pointing to our issue or the upstream issue.

[altendky]

So my only concern with going ahead with this is that there still might be something funny going on with the added pytest-twisted test when running with qt5reactor. Might be nothing, might be irrelevant, I haven't spent any time on it yet. Anyways, just wanted to mention that. But hey, if more versions are found to be problematic they can be listed later.

[kmike]

Thanks so much @altendky for making pytest-twisted working for us!