Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Avoid .callback() in TestProcessProtocol.processEnded() #4426

Closed
wants to merge 3 commits into from
Closed

[WIP] Avoid .callback() in TestProcessProtocol.processEnded() #4426

wants to merge 3 commits into from

Conversation

altendky
Copy link
Contributor

@altendky
Copy link
Contributor Author

Even if tests pass I do not know at present if this is the correct fix or not. I'll follow up as I piece together some basis one way or the other.

@altendky altendky mentioned this pull request Mar 14, 2020
Open
@altendky
Copy link
Contributor Author

This was exploratory, exploration complete, still an underlying issue but perhaps there's a Twisted change to address the symptom... pytest-dev/pytest-twisted#93 (comment)

@altendky altendky closed this Mar 30, 2020
@altendky altendky deleted the maybe_fix_processprotocol branch March 30, 2020 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@altendky