Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin build environment to Trusty for Jessie builds #3922

Closed
wants to merge 1 commit into from

Conversation

dangra
Copy link
Member

@dangra dangra commented Jul 31, 2019

Fixes #3917

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #3922 into 1.7 will increase coverage by 0.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              1.7    #3922      +/-   ##
==========================================
+ Coverage   85.01%   85.56%   +0.55%     
==========================================
  Files         164      164              
  Lines        9567     9567              
  Branches     1436     1436              
==========================================
+ Hits         8133     8186      +53     
+ Misses       1180     1133      -47     
+ Partials      254      248       -6
Impacted Files Coverage Δ
scrapy/pipelines/files.py 66.53% <0%> (+1.15%) ⬆️
scrapy/core/scraper.py 88.51% <0%> (+2.02%) ⬆️
scrapy/core/downloader/handlers/http11.py 92.53% <0%> (+2.61%) ⬆️
scrapy/extensions/feedexport.py 83.48% <0%> (+5.04%) ⬆️
scrapy/core/downloader/tls.py 90% <0%> (+12.5%) ⬆️
scrapy/utils/boto.py 73.33% <0%> (+26.66%) ⬆️
scrapy/core/downloader/handlers/s3.py 95.16% <0%> (+32.25%) ⬆️

@dangra
Copy link
Member Author

dangra commented Jul 31, 2019

After thinking it a bit more I prefer #3923 approach

@dangra dangra closed this Jul 31, 2019
@dangra dangra deleted the fix-jessie-build branch July 31, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant