-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+1] Update _monkeypatches.py #3907
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,4 @@ | ||
import six | ||
from six.moves import copyreg | ||
|
||
|
||
if six.PY2: | ||
from urlparse import urlparse | ||
|
||
# workaround for https://bugs.python.org/issue7904 - Python < 2.7 | ||
if urlparse('s3://bucket/key').netloc != 'bucket': | ||
from urlparse import uses_netloc | ||
uses_netloc.append('s3') | ||
|
||
# workaround for https://bugs.python.org/issue9374 - Python < 2.7.4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we shouldn't remove the second workaround, as it may be needed in 2.7 < Python < 2.7.4 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep my bad, python 2.7.4 is still permitted . I am newbie to the whole project so this may sound stupid but why is the Travis CI build is failing? I noticed it with other pull requests too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added the second workaround in the new commit.Could you review the new code? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
if urlparse('s3://bucket/key?key=value').query != 'key=value': | ||
from urlparse import uses_query | ||
uses_query.append('s3') | ||
|
||
|
||
# Undo what Twisted's perspective broker adds to pickle register | ||
# to prevent bugs like Twisted#7989 while serializing requests | ||
import twisted.persisted.styles # NOQA | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍