Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around tox #1369 #3917

Closed
Gallaecio opened this issue Jul 30, 2019 · 5 comments · Fixed by #3923
Closed

Work around tox #1369 #3917

Gallaecio opened this issue Jul 30, 2019 · 5 comments · Fixed by #3923
Labels
CI

Comments

@Gallaecio
Copy link
Member

The Jessie build is affected by tox-dev/tox#1369, which may be hiding a different issue.
@Gallaecio Gallaecio added the CI label Jul 30, 2019
@Gallaecio
Copy link
Member Author

This seems to be the only remaining persistent CI issue at the moment after #3913 is merged.

@Gallaecio Gallaecio mentioned this issue Jul 30, 2019
Merged
@wRAR
Copy link
Member

wRAR commented Jul 30, 2019 •
edited

The Jessie build started failing after the base image switched to xenial, as can be seen in travis job logs. A manual run shows that cryptography 0.6.1 can't be built with xenial's OpenSSL.

https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment says it should have happened some time ago but PRs older than several days were still tested on trusty.

@kmike
Copy link
Member

kmike commented Jul 30, 2019

I think we may pin tox version in the meantime.

@dangra
Copy link
Member

dangra commented Jul 31, 2019

I think we may pin tox version in the meantime.

Not sure if it is clear what version of tox broke the build, it looks like the tox bug has been there for a long time and Travis-ci switch to Xenial just uncovered it.

My understanding after reading @wRAR's comment and travis-ci blog is that distribution should be pinned to trusty in .travis.yml for 1.7 branch.

For 1.8+, minimum version will be upgraded to Xenial (by dropping Jessie and similars) as commented in #3892 (comment)

dangra added a commit that referenced this issue Jul 31, 2019
@dangra
Pin build environment to Trusty for Jessie builds
27e0bdf 
Fixes #3917
@dangra dangra mentioned this issue Jul 31, 2019
Closed
dangra added a commit that referenced this issue Jul 31, 2019
@dangra
Pin Travis-ci build environment to previous default: Trusty
7333fc0 
Travis-ci changed the default build environment to Xenial as explained in https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment
This causes builds meant for Debian Jessie to break as noted by @wRAR in #3917 (comment)

This change pins the environment to known working ubuntu trusty distribution prior to dropping Jessie support and upgrade to Xenial as base.

Closes #1369
@dangra dangra mentioned this issue Jul 31, 2019
Merged
@dangra
Copy link
Member

dangra commented Jul 31, 2019

Fix proposed at #3923

dangra added a commit that referenced this issue Jul 31, 2019
@dangra
Pin Travis-ci build environment to previous default: Trusty
0287701 
Travis-ci changed the default build environment to Xenial as explained in https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment
This causes builds meant for Debian Jessie to break as noted by @wRAR in #3917 (comment)

This change pins the environment to known working ubuntu trusty distribution prior to dropping Jessie support and upgrade to Xenial as base.

Closes #1369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin Travis-ci build environment to previous default: Trusty scrapy/scrapy
4 participants
@dangra @kmike @wRAR @Gallaecio