Merge pull request #3918 from rennerocha/fix-lxml-py34

Added constrain on lxml version to avoid error when using Python 3.4 (#3912)
scrapy · Jul 31, 2019 · c5b8cc4 · c5b8cc4
2 parents 1a289c1 + 5c916be
commit c5b8cc4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/requirements-py3.txt b/requirements-py3.txt
@@ -1,5 +1,6 @@
 Twisted>=17.9.0
-lxml>=3.2.4
+lxml;python_version!="3.4"
+lxml<=4.3.5;python_version=="3.4"
 pyOpenSSL>=0.13.1
 cssselect>=0.9
 queuelib>=1.1.1

diff --git a/setup.py b/setup.py
@@ -69,7 +69,8 @@ def has_environment_marker_platform_impl_support():
         'Twisted>=13.1.0,<=19.2.0;python_version=="3.4"',
         'w3lib>=1.17.0',
         'queuelib',
-        'lxml',
+        'lxml;python_version!="3.4"',
+        'lxml<=4.3.5;python_version=="3.4"',
         'pyOpenSSL',
         'cssselect>=0.9',
         'six>=1.5.2',

diff --git a/tests/constraints.txt b/tests/constraints.txt
@@ -1,2 +1 @@
-Twisted!=18.4.0
-lxml!=4.2.2
+Twisted!=18.4.0