Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding set object to itemloader #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix adding set object to itemloader #85

wants to merge 1 commit into from

Conversation

VMRuiz
Copy link
Contributor

@VMRuiz VMRuiz commented May 14, 2024

No description provided.

@VMRuiz VMRuiz mentioned this pull request May 14, 2024
Open
@VMRuiz
Copy link
Contributor Author

VMRuiz commented May 14, 2024 •
edited

Some test are failing because the list contains the element in a different order, not sure if I should fix the test or the code itself...

@Gallaecio
Copy link
Member

The test, I think.

@wRAR
Copy link
Member

wRAR commented May 30, 2024

I wonder why is it failing on 3.9 and 3.10, I don't think anything changed in 3.11 related to collection order? And I checked locally, list({"foo", "bar"}) == ['bar', 'foo'] on all versions that I checked, including 3.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VMRuiz @Gallaecio @wRAR