ItemAdapter.get_field_names_from_class #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 291 318 +27
=========================================
+ Hits 291 318 +27
Help us with your feedback. Take ten seconds to tell us how you rate us. |
kmike
commented
Aug 1, 2022
| @@ -43,10 +43,13 @@ def test_module_import_error(self): | |||
| from itemadapter.adapter import DataclassAdapter | |||
|
|
|||
| self.assertFalse(DataclassAdapter.is_item(DataClassItem(name="asdf", value=1234))) | |||
| with self.assertRaises(RuntimeError, msg="attr module is not available"): | |||
| with self.assertRaises(RuntimeError, msg="dataclasses module is not available"): | |||
There was a problem hiding this comment.
I'm not sure why it's been passing. Probably, assertRaises doesn't work as intended here.
There was a problem hiding this comment.
I believe that is the message that shows if the assert fails. We can use assertRaisesRegex if the goal is for the assert of fail if the exception message does not match this one.
kmike
referenced
this pull request
in scrapinghub/web-poet
Aug 2, 2022
|
Thanks for merging it @elacuesta! |
|
Awesome, thanks @elacuesta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey! This PR adds a new ItemAdapter classmethod: get_field_names_from_class - similar to get_field_names, but accepts item class, not an item itself. It's motivated by scrapinghub/web-poet#53 (comment).