Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate undocumented predicates from the utils module #56

Merged
merged 17 commits into from Sep 20, 2021
Merged

Deprecate undocumented predicates from the utils module #56

merged 17 commits into from Sep 20, 2021

Commits on Aug 9, 2021

  1. ItemAdapter.is_item_class and ItemAdapter.get_field_meta_from_class

    @elacuesta
    elacuesta committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    0b558d5 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. f-string formatting

    @elacuesta
    elacuesta committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    6cdd92d View commit details
    Browse the repository at this point in the history

  2. Make is_item_class an abstract method, improve test coverage

    @elacuesta
    elacuesta committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    8467f34 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. simplify get_field_meta methods

    @elacuesta
    elacuesta committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    ca05f4a View commit details
    Browse the repository at this point in the history

  2. Document ItemAdapter.is_item_class

    @elacuesta
    elacuesta committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    aac1aa0 View commit details
    Browse the repository at this point in the history

  3. Document ItemAdapter.get_field_meta_from_class

    @elacuesta
    elacuesta committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    fb17610 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Update README.md 

    Co-authored-by: Adrián Chaves <adrian@chaves.io>
    @elacuesta @Gallaecio
    elacuesta and Gallaecio committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    8ca798b View commit details
    Browse the repository at this point in the history

  2. Update README.md 

    Co-authored-by: Adrián Chaves <adrian@chaves.io>
    @elacuesta @Gallaecio
    elacuesta and Gallaecio committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    bc47261 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary stuff

    @elacuesta
    elacuesta committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    fdcd266 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Default implementation for is_item based on is_item_class

    @elacuesta
    elacuesta committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    758584b View commit details
    Browse the repository at this point in the history

  2. Remove commented code in test

    @elacuesta
    elacuesta committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    4c0a2bf View commit details
    Browse the repository at this point in the history

  3. use ItemAdapter.is_item instead of is_item

    @elacuesta
    elacuesta committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    383a89d View commit details
    Browse the repository at this point in the history

  4. Deprecate itemadapter.utils.is_dataclass_instance

    @elacuesta
    elacuesta committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    b714180 View commit details
    Browse the repository at this point in the history

  5. Deprecate itemadapter.utils.is_attrs_instance

    @elacuesta
    elacuesta committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    2746ae7 View commit details
    Browse the repository at this point in the history

  6. Deprecate itemadapter.utils.is_pydantic_instance

    @elacuesta
    elacuesta committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    f9ea9b5 View commit details
    Browse the repository at this point in the history

  7. Deprecate itemadapter.utils.is_scrapy_item

    @elacuesta
    elacuesta committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    e4fbecc View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Merge branch 'master' into deprecate-stuff

    @elacuesta
    elacuesta committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    34527a1 View commit details
    Browse the repository at this point in the history