Allow empty strings in asserts (#130)

scrapy · Oct 25, 2022 · 0d5e380 · 0d5e380
1 parent 02eff50
commit 0d5e380
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/cssselect/xpath.py b/cssselect/xpath.py
@@ -673,14 +673,14 @@ def xpath_attrib_exists(self, xpath: XPathExpr, name: str, value: Optional[str])
         return xpath
 
     def xpath_attrib_equals(self, xpath: XPathExpr, name: str, value: Optional[str]) -> XPathExpr:
-        assert value
+        assert value is not None
         xpath.add_condition("%s = %s" % (name, self.xpath_literal(value)))
         return xpath
 
     def xpath_attrib_different(
         self, xpath: XPathExpr, name: str, value: Optional[str]
     ) -> XPathExpr:
-        assert value
+        assert value is not None
         # FIXME: this seems like a weird hack...
         if value:
             xpath.add_condition("not(%s) or %s != %s" % (name, name, self.xpath_literal(value)))
@@ -703,7 +703,7 @@ def xpath_attrib_includes(
     def xpath_attrib_dashmatch(
         self, xpath: XPathExpr, name: str, value: Optional[str]
     ) -> XPathExpr:
-        assert value
+        assert value is not None
         # Weird, but true...
         xpath.add_condition(
             "%s and (%s = %s or starts-with(%s, %s))"