[429] Fix default templates non-subscriptable problem #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #451 +/- ##
=======================================
Coverage 79.51% 79.51%
=======================================
Files 76 76
Lines 3237 3237
Branches 537 537
=======================================
Hits 2574 2574
Misses 593 593
Partials 70 70 ☔ View full report in Codecov by Sentry. |
VMRuiz
approved these changes
May 16, 2024
curita
approved these changes
May 29, 2024
| @@ -44,7 +44,7 @@ def test_add_job_tags(test_settings): | |||
| add_job_tags.data = MagicMock() | |||
| add_job_tags.data.job.metadata = SettableDict({"tags": []}) | |||
| add_job_tags.run_action() | |||
| assert add_job_tags.data.job.metadata["tags"] == ["add_foo", "add_bar"] | |||
| assert add_job_tags.data.job.metadata.get("tags") == ["add_foo", "add_bar"] | |||
There was a problem hiding this comment.
praise: Thank you for updating the tests as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all instances of
data.job.metadata[x]in the templates withdata.job.metadata.get(x).