Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing issues for typed Scrapy. #166

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Fix typing issues for typed Scrapy. #166

wants to merge 5 commits into from

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Sep 21, 2023

Remaining issues are related to scrapy/scrapy#5989 and to typed Spider.parse().

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #166 (dede201) into master (aba2b74) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head dede201 differs from pull request most recent head 5e6238d. Consider uploading reports for the commit 5e6238d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   85.85%   85.87%   +0.01%     
==========================================
  Files          14       14              
  Lines         813      814       +1     
==========================================
+ Hits          698      699       +1     
  Misses        115      115              
Files Coverage Δ
scrapy_poet/downloadermiddlewares.py 100.00% <100.00%> (ø)
scrapy_poet/injection.py 98.54% <100.00%> (+0.01%) ⬆️
scrapy_poet/page_input_providers.py 100.00% <100.00%> (ø)
scrapy_poet/spidermiddlewares.py 100.00% <100.00%> (ø)
scrapy_poet/utils/__init__.py 97.82% <100.00%> (ø)
scrapy_poet/utils/testing.py 77.16% <ø> (-0.70%) ⬇️

@wRAR wRAR marked this pull request as draft September 21, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant