Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrapy 2.11.1 and scrapinghub-entrypoint-scrapy 0.17.2 #185

Closed
wants to merge 3 commits into from

Conversation

Gallaecio
Copy link
Member

No description provided.

@wRAR
Copy link
Member

wRAR commented Feb 20, 2024

No other version changes in requirements.txt? Did you regenerate it?

@Gallaecio
Copy link
Member Author

I updated it with pip-compile, but I did not remove the .txt first to get the latest versions of everything, I assume we only do that with stack version changes.

@elacuesta
Copy link
Member

elacuesta commented Feb 20, 2024

I've been regenerating the requirements file for every change, whether it's a patch or minor update. Also in this case, we might want to update Twisted from 22.10 to a more recent version now that Scrapy 2.11.1 supports it.

@Gallaecio
Copy link
Member Author

Feels risky to me, but will do.

Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but probably it'd be better to run the upgrade one more time (e.g. scrapy-zyte-smartproxy got a new release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants