Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix portia_server #921

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

Conversation

milahu
Copy link

@milahu milahu commented Apr 4, 2022

this PR is abandoned in favor of Gerapy

fix #883 #920 #913 #907 #903 #902 #895 #877 #842 #812 #811 #790 #760 #742 ...

todo

  • fix portia_server
    • bump version from 2.0.8 to 2.1.0
  • fix slybot (at least the build is working, may produce runtime errors)
    • fix some snapshot tests
  • fix portiaui
  • fix slyd
  • support frames frame and iframe support in Portia #494

related
scrapinghub/portia2code#12
scrapy/scrapely#122

@Clarence-G
Copy link

Thank you very much for your contribution. I recently strongly needed a working version. How to compile and run the branch?

@milahu
Copy link
Author

milahu commented Apr 14, 2022

im using nix for packaging, as it gives great flexibility.
when you're on linux, nix is easy to install ... on windows, you need WSL
save the build file portia-server.nix and run

nix-build -E 'with import <nixpkgs> { }; callPackage ./portia-server.nix { }'
./result/bin/portia-server --help

note, this branch is a work in progress

the python code is "basically working"

the javascript code is on my todo list, something with this,
probably npmlock2nix as portiaui is using the npm lockfile package-lock.json
ideally update dependencies and fix API changes ... yay

@Clarence-G
Copy link

@milahu Thanks for your explanation. I have installed nix on WSL. But I couldn't find the build file portia-server.nix. So how to wrtie the build file?

@milahu milahu force-pushed the fix-portia_server branch 2 times, most recently from 76a0ae8 to e69f9ed Compare April 15, 2022 17:32
@milahu
Copy link
Author

milahu commented Apr 15, 2022

I have installed nix on WSL

cool. is it working? ^^

nix-shell -p cowsay --run 'cowsay "yepp, nix seems to work"'

I couldn't find the build file portia-server.nix

see my first post, but thats an old version

how good is your javascript and python?
if you want to help, i can share my current nix build files
so you can (hopefully) reproduce my development environment

basically im just printing variables and googling for error messages ...

@milahu
Copy link
Author

milahu commented Apr 17, 2022

slowly getting there ...

Screenshot_2022-04-17_23-59-05 portia scrapy gui

google captcha throws Frames are not supported by Portia#494

Screenshot_2022-04-18_00-00-35 portia bug Frames are not supported by Portia

@milahu
Copy link
Author

milahu commented Apr 18, 2022

abandoning this PR in favor of Gerapy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is this project dead?
2 participants