Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse unix timestamps consistently regardless of timezones #954

Merged
merged 4 commits into from Sep 20, 2022
Merged

Parse unix timestamps consistently regardless of timezones #954

merged 4 commits into from Sep 20, 2022

Commits on Jul 27, 2021

  1. test coverage for how unix timestamps are parsed

    @onlynone
    onlynone committed Jul 27, 2021
    Copy the full SHA
    60d8003 View commit details
    Browse the repository at this point in the history

  2. Consider the local tz when creating a datetime object from timestamp 

    Otherwise datetime.fromtimestamp will return a naive datetime in the
local timezone and applying timezone modifications later with TIMEZONE
and TO_TIMEZONE won't do the right thing.

Parsing a unix timestamp value should always result in the exact same
instant in time regardless of current time zone, so it shouldn't matter
what the current TIMEZONE setting is, whether 'UTC', 'local', any other
timezone, or even unset.
    @onlynone
    onlynone committed Jul 27, 2021
    Copy the full SHA
    3faf65f View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Merge branch 'master' into parse_unix_timestamps

    @onlynone
    onlynone committed Jun 21, 2022
    Copy the full SHA
    3e8b347 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. Clarify logic for timezones when parsing unix timestamps

    @onlynone
    onlynone committed Sep 3, 2022
    Copy the full SHA
    6934648 View commit details
    Browse the repository at this point in the history