Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding set to utf-8 causing UnicodeDecode errors in windows #1027

Closed
wants to merge 1 commit into from

Conversation

dhananjaypai08
Copy link

@dhananjaypai08 dhananjaypai08 commented Dec 13, 2021

Closes #978
Encoding set to utf-8 wherever not present while opening a file causing the error in windows : "UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position line_number: character maps to something undefined"

@dhananjaypai08 dhananjaypai08 changed the title encoding set to utf-8 causing UnicodeDecode errors encoding set to utf-8 causing UnicodeDecode errors in windows Dec 13, 2021
@lopuhin
Copy link
Member

lopuhin commented Dec 14, 2021

Thanks for the PR @dhananjaypai08 👍
I think it's the same as #998 (but yours does not have a line endings issue), I think it makes sense to merge #998 if the author fixes the line endings issue soon.

@lopuhin
Copy link
Member

lopuhin commented Dec 14, 2021

Issue #978 is fixed by #998 now - sorry for delay with getting it reviewed and merged. I'll close this one as the same changes are already present in master - thank you for the PR though 👍 And sorry for creating a situation which resulted in a duplicate PR.

@lopuhin lopuhin closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants