Allow to use_given_order for languages too (#997)

scrapinghub · Oct 27, 2021 · 5ec1a6e · 5ec1a6e
1 parent 8af4f29
commit 5ec1a6e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/dateparser/date.py b/dateparser/date.py
@@ -358,8 +358,8 @@ def __init__(self, languages=None, locales=None, region=None, try_previous_local
             raise TypeError("use_given_order argument must be a boolean (%r given)"
                             % type(use_given_order))
 
-        if not locales and use_given_order:
-            raise ValueError("locales must be given if use_given_order is True")
+        if not locales and not languages and use_given_order:
+            raise ValueError("locales or languages must be given if use_given_order is True")
 
         check_settings(settings)
 

diff --git a/tests/test_date.py b/tests/test_date.py
@@ -652,10 +652,13 @@ def test_error_raised_for_invalid_use_given_order_argument(self, use_given_order
             TypeError, ["use_given_order argument must be a boolean (%r given)"
                         % type(use_given_order)])
 
-    def test_error_is_raised_when_use_given_order_is_True_and_locales_is_None(self):
+    def test_error_is_raised_when_use_given_order_is_True_and_locales_and_languages_is_None(self):
         self.when_parser_is_initialized(use_given_order=True)
         self.then_error_was_raised(
-            ValueError, ["locales must be given if use_given_order is True"])
+            ValueError, ["locales or languages must be given if use_given_order is True"])
+
+    def test_no_error_for_order_with_languages_without_locales(self):
+        self.when_parser_is_initialized(languages=['en', 'fr'], use_given_order=True)
 
     def when_parser_is_initialized(self, languages=None, locales=None, region=None,
                                    try_previous_locales=True, use_given_order=False):