Tokio 1.0 #22
Merged
Tokio 1.0 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you!
I think there's some interoperability testing benefit to using reqwest. If you're happy waiting, I think it's probably better to keep that. I see there's a reqwest issue and PR for the upgrade, and seanmonstar said it's coming soon. |
|
Tests notwithstanding, I can confirm that |
|
Looks like the new reqwest is released. :-) |
|
Updated. |
|
CI passes now, too (finally). |
scottlamb
approved these changes
Jan 9, 2021
|
Can you also publish a new version when you find time? Thanks. |
scottlamb
reviewed
Jan 9, 2021
|
Published, and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21
The tests currently fail because of an executor mismatch with
reqwest. We can either wait for it to be updated, or rewrite the tests to use thehyperclient.