Skip to content

Commit

Permalink
chore(pre-commit): remove pytype
Browse files Browse the repository at this point in the history
It's largely redundant with mypy, quite slow, causes some special
considerations for our setup, and quite a lot of renovate traffic.
  • Loading branch information
scop committed Nov 15, 2021
1 parent a31135d commit 82469aa
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 22 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
# First, the Python matching pytype's python_version
- uses: actions/setup-python@v2
with:
python-version: 3.6
# Then, the "main" Python we run things with. pre-commit/action uses this
- uses: actions/setup-python@v2
with:
python-version: 3.8
Expand All @@ -31,7 +26,6 @@ jobs:
python3.8 -m venv venv
source venv/bin/activate
python3.8 -m pip install -Ur requirements-dev.txt
python3.6 -m pip install -Ur requirements-test.txt
- uses: pre-commit/action@v2.0.3

test:
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
.coverage
.eggs/
.python-version
.pytype/
.tox/
__pycache__/
build/
Expand Down
9 changes: 0 additions & 9 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,6 @@ repos:
entry: venv-run mypy
types: [python]

- id: pytype
name: pytype
language: python
additional_dependencies:
- #
venv-run ==0.1.0
entry: venv-run pytype
types: [python]

- id: pylint
name: pylint
language: python
Expand Down
2 changes: 0 additions & 2 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,4 @@ pylint-strict-informational ==0.1

python-language-server

pytype ==2021.8.24

pyupgrade ==2.24.0
4 changes: 0 additions & 4 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ warn_unreachable = True
# variable annotations in newer pytest, errors out with python_version < 3.6
follow_imports = skip

[pytype]
# Too many/hard to avoid problems with variable annotations and < 3.6
python_version = 3.6

[coverage:report]
exclude_lines =
if __name__ == .__main__.:
Expand Down

0 comments on commit 82469aa

Please sign in to comment.