Add completion for bluetoothctl #742
Conversation
There was a problem hiding this comment.
Thank you for your contribution.
Have you checked CONTRIBUTING.md and consulted with the upstream BlueZ about it? The Zsh completion seems to be already in the repository, so I guess they would accept your contribution to the upstream. They seem to accept patches through the developer mailing list.
| { | ||
| local cur=${COMP_WORDS[COMP_CWORD]} | ||
| local prev=${COMP_WORDS[COMP_CWORD-1]} | ||
| if [[ "$COMP_CWORD" == "1" ]]; then |
There was a problem hiding this comment.
| if [[ "$COMP_CWORD" == "1" ]]; then | |
| if ((COMP_CWORD == 1)); then |
- You can use the arithmetic command.
The same applies to the later lines testing COMP_CWORD.
| local prev=${COMP_WORDS[COMP_CWORD-1]} | ||
| if [[ "$COMP_CWORD" == "1" ]]; then | ||
| # Parse help for list of commands and remove ansi colors | ||
| COMPREPLY=( $( compgen -W "$(bluetoothctl help | sed -n '/ /{s/\x1B\[[0-9;]*[a-zA-Z]//g;s/\x01//g;s/\x02//g;s/ .*//p}')" -- $cur)) |
There was a problem hiding this comment.
| COMPREPLY=( $( compgen -W "$(bluetoothctl help | sed -n '/ /{s/\x1B\[[0-9;]*[a-zA-Z]//g;s/\x01//g;s/\x02//g;s/ .*//p}')" -- $cur)) | |
| COMPREPLY=( $( compgen -W "$(bluetoothctl help | sed -n '/ /{s/\x1B\[[0-9;]*[a-zA-Z]//g;s/\x01//g;s/\x02//g;s/ .*//p}')" -- "$cur")) |
- quoting
| COMPREPLY=( $( compgen -W "$(bluetoothctl help | sed -n '/ /{s/\x1B\[[0-9;]*[a-zA-Z]//g;s/\x01//g;s/\x02//g;s/ .*//p}')" -- $cur)) | |
| COMPREPLY=( $( compgen -W "$(bluetoothctl help | sed -n '/ /{s/\x1B\[[0-9;]*[a-zA-Z]//g;s/\x01//g;s/\x02//g;s/ .*//p;}')" -- $cur)) |
- POSIX sed requires a semicolon or newline before <right-brace>.
| COMPREPLY=( $( compgen -W "$(bluetoothctl help | sed -n '/ /{s/\x1B\[[0-9;]*[a-zA-Z]//g;s/\x01//g;s/\x02//g;s/ .*//p}')" -- $cur)) | |
| COMPREPLY=( $( compgen -W "$(bluetoothctl help | sed -n '/ /{s/'$'\e''\[[0-9;]*[a-zA-Z]//g;s/['$'\x01\x02'']//g;s/ .*//p}')" -- $cur)) |
- AFAIK, POSIX sed doesn't necessarily support the escape sequences like
\x1B. Here, I'd suggest expanding the sequences using Bash's$'...'before passing it tosed.
These comments also apply to the later lines that contain the same structure.
There was a problem hiding this comment.
In that case, it might just be better to not use sed at all. I think this should be doable in bash only.
There was a problem hiding this comment.
Yeah, I think either works, so you can use what you like.
| info|pair|trust|untrust|block|unblock|remove|connect|disconnect) | ||
| # Return a device to complete | ||
| COMPREPLY=( $( compgen -W "$(bluetoothctl devices|awk '{print $2}')" -- $cur)) | ||
| ;; |
There was a problem hiding this comment.
| ;; | |
| ;; |
- The indentation seems to be inconsistent with the other similar lines?
| fi | ||
| if [[ "$COMP_CWORD" == "3" ]]; then |
There was a problem hiding this comment.
| fi | |
| if [[ "$COMP_CWORD" == "3" ]]; then | |
| elif ((COMP_CWORD" == 3)); then |
| fi | ||
| fi | ||
| } | ||
|
|
There was a problem hiding this comment.
I think complete -F _bluetoothctl bluetoothctl is missing.
| _bluetoothctl() | ||
| { | ||
| local cur=${COMP_WORDS[COMP_CWORD]} | ||
| local prev=${COMP_WORDS[COMP_CWORD-1]} |
There was a problem hiding this comment.
If you intend to use the auto-loading mechanism of bash-completion (i.e., putting the file in the completions directory and letting bash-completion load it automatically on demand), I suggest using _init_completion for the initialization (as done in other completions). It doesn't only provide a better extraction of the words but also the contextual completions for the variable names and redirections. It might also be used by bash-completion for hooks in the future.
|
Good point, have not consulted with BlueZ, I will do that, and fix the points you mentioned first. Is it OK if I close this, and reopen if upstream prefer it here? Thank you for your time, I appreciate it. |
Sure! |
I've used this for some months now and thought I'd share in the hope that it's useful for someone else.
Please let me know of any changes I should make to make it fit in here. I tried my best, but since it's my first completion i might have missed something.