-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ruby OpenShift 4 tests suite and and 3.3 imagestreams #540
Conversation
[test-openshift] |
Set VERSION to unset in 3.3/Dockerfile.fedora Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
b37b3b4
to
fa0cce4
Compare
[test-all] |
Settings variable to 'VERSION=' or 'VERSION=""' cause a problems in our testing suite. See here: https://github.com/sclorg/container-common-scripts/blob/master/tag.sh#L35 it raises an exception like:
We need to change this row https://github.com/sclorg/container-common-scripts/blob/master/tag.sh#L35 |
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
acc810b
to
883c4be
Compare
[test-all] |
Can't see anything weird that would hit me in the eyes. LGTM. Thanks. |
Co-authored-by: Zuzana Miklánková <zmiklank@redhat.com>
[test-openshift] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to avoid commit messages like "Update imagestreams/ruby-rhel-aarch64.json". They do not add much value to the commit.
Otherwise LGTM.
This is a message from commit suggestions as soon as I approve. |
It can be changed before approving and commiting. |
This pull request fixes OpenShift 4 tests for version 3.3.
In case ruby 3.3 is tested, then use rails-ex#3.3 branch as well.
In this pull request are updated also 3.3 imagestreams