Support for Testing Python container by container-ci-suite #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft 4 Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
| @@ -0,0 +1,73 @@ | |||
| import os | |||
| import sys | |||
| import pytest | |||
There was a problem hiding this comment.
If you split imports, there are usually three groups: standard library, third-party libs (installed dependencies) and local modules.
|
|
||
| from container_ci_suite.openshift import OpenShiftAPI | ||
| from container_ci_suite.utils import get_service_image, check_variables | ||
| test_dir = Path(os.path.abspath(os.path.dirname(__file__))) |
There was a problem hiding this comment.
You use all upper case names for constant and this is also constant.
| IMAGE_TAG = "postgresql:10" | ||
| PSQL_VERSION = "10" | ||
|
|
||
| if OS == "rhel7": |
There was a problem hiding this comment.
A dictionary (mapping) might be better than many ifs.
| test_dir = Path(os.path.abspath(os.path.dirname(__file__))) | ||
|
|
||
| if not check_variables(): | ||
| sys.exit(1) |
There was a problem hiding this comment.
What about some error message here is the exit code is non-zero?
There was a problem hiding this comment.
The messages are here: https://github.com/sclorg/container-ci-suite/blob/main/container_ci_suite/utils.py#L242.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request uses testing s2i-python-container in OpenShift 4 environment
by container-ci-suite.