Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: integrate.quad_vec: deprecate quadrature="trapz" #20716

Merged
merged 3 commits into from
May 24, 2024

Conversation

j-bowhay
Copy link
Member

@j-bowhay j-bowhay commented May 15, 2024

Reference issue

towards #20486

What does this implement/fix?

Allows for cleaning up one of the final trapz references, which we have removed elsewhere as it is not an especially helpful acronym and can be interpreted as a slur.

Also tidies up some functions in the refguide check that no longer exist.

Additional information

Post to the development forum to follow once I do the other half of #20486

@j-bowhay j-bowhay added this to the 1.14.0 milestone May 15, 2024
@github-actions github-actions bot added scipy.integrate deprecated Items related to behavior that has been deprecated labels May 15, 2024
Copy link
Contributor

@mdhaber mdhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my phone; I'll just test it locally before merging.

@mdhaber
Copy link
Contributor

mdhaber commented May 15, 2024

Documentation was already OK. Test looks good, and locally I see that we get the warning with method='trapz' and not with method='trapezoid'. Thanks @j-bowhay!

@mdhaber
Copy link
Contributor

mdhaber commented May 15, 2024

Ah, I see you intended to propose this on the forum before merging. I thought we had already decided that all these references would be removed, but it's up to you. LMK when you want this merged.

@lucascolley lucascolley changed the title DEP integrate.quad_vec: deprecate quadrature="trapz" DEP: integrate.quad_vec: deprecate quadrature="trapz" May 17, 2024
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from a typo

scipy/integrate/_quad_vec.py Outdated Show resolved Hide resolved
[skip ci]

Co-authored-by: h-vetinari <h.vetinari@gmx.com>
@j-bowhay
Copy link
Member Author

Two approvals and no complaints from the mailing list so going to push the button on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated Items related to behavior that has been deprecated scipy.integrate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants