-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: integrate.quad_vec: deprecate quadrature="trapz"
#20716
Conversation
fccd1fe
to
505a711
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my phone; I'll just test it locally before merging.
Documentation was already OK. Test looks good, and locally I see that we get the warning with |
Ah, I see you intended to propose this on the forum before merging. I thought we had already decided that all these references would be removed, but it's up to you. LMK when you want this merged. |
quadrature="trapz"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from a typo
[skip ci] Co-authored-by: h-vetinari <h.vetinari@gmx.com>
Two approvals and no complaints from the mailing list so going to push the button on this. |
Reference issue
towards #20486
What does this implement/fix?
Allows for cleaning up one of the final trapz references, which we have removed elsewhere as it is not an especially helpful acronym and can be interpreted as a slur.
Also tidies up some functions in the refguide check that no longer exist.
Additional information
Post to the development forum to follow once I do the other half of #20486