MAINT: stats.yulesimon: fix kurtosis #20654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
scipy.stats
maintenance
[skip cirrus] [skip circle]
mdhaber
commented
May 6, 2024
|
Thanks @mdhaber ! |
mdhaber
added
the
backport-candidate
10 tasks
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-20648
What does this implement/fix?
Fixes a typo in the the
yulesimonimplementation of the kurtosis. Removed its exemption from generic kurtosis test that is sensitive to the bug. Changed the test to filter warnings rather than exempt distributions.Additional information
The parameters chosen for the
zipfdistribution plot does not produce a great plot - basically just a point mass. This doesn't (/can't) make it any worse, though, and I'd rather not do a deep dive to fix that right now. (Better parameters cause warnings elsewhere.)