New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: updated preconditioner doc for iterative linear solver #20517
base: main
Are you sure you want to change the base?
DOC: updated preconditioner doc for iterative linear solver #20517
Conversation
f1a7dfc
to
868d336
Compare
Thanks for the contribution! These are just typo fixes. Someone familiar with the math still needs to review this. |
Thank you @Afleloup I think this is conflating the point here a bit too much. Just because the argument name is The theoretical treatment is irrelevant here since the operator name can be anything. It's utility is important. The point of all the inverses attached to M is to emphasize that it kinda sorta inverts A. But in fact it does a more important thing which is, ideally, improves the condition number of the LHS. Hence inverse is a red herring here. The existing docs read correct to me, but can be clarified for the mismatch with the literature. Note that the preconditioner definition is all over the place, as noted with the wiki page you added as a reference
|
Thanks, I will change it this way then. I didn't see the sentence you mentioned in the wikipedia article and thought the literature I had was consistent with the other notation. |
No problem, thank you for tackling this issue regardless. |
4bde210
to
9e03ced
Compare
linear solver The argument M in iterative linear solver 'bicg', 'bicgstab', 'cg', 'cgs' has different notations in the literature. Its usage has been clarified. Their should be a precondition on M for the preconditioned conjugate gradient. It is now explicited in the documentation and linked to relevant references. Closes scipy#5818
9e03ced
to
b9125b3
Compare
Closes #5818
Reference issue
What does this implement/fix?
Additional information
References