BUG: Fix raising ValueError on a zero-size array for SciPy.special.logsumexp #20511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gsumexp scipy.special.logsumexp raises a ValueError for a zero-size array even though mathematically the correct answer for a zero-size array is -inf Closes scipy#20399
github-actions
bot
added
scipy.special
defect
tupui
approved these changes
Apr 17, 2024
|
Thanks @tomita-militaru LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-20399
What does this implement/fix?
scipy.special.logsumexpraises aValueErrorfor a zero-size array even though mathematically the correct answer for a zero-size array is-inf, so I've added a check for empty array as simply adding toinitialvalue-np.infdoes not work due to typing issues when using for eg. integers in array.