Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: replace interp2d by stub #20497

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

h-vetinari
Copy link
Member

Towards #18583, details & references in that issue.

@h-vetinari h-vetinari added scipy.interpolate deprecated Items related to behavior that has been deprecated labels Apr 16, 2024
@h-vetinari h-vetinari requested a review from ev-br April 16, 2024 23:40
@h-vetinari
Copy link
Member Author

The last commit here can be omitted if we merge #19904 first.

@h-vetinari h-vetinari mentioned this pull request Apr 17, 2024
36 tasks
@h-vetinari
Copy link
Member Author

So now we have the issue that the transition guide wants to execute interp2d, which is obviously not possible anymore. Should we simply delete the guide and in the error/docstring refer to the 1.13 transition guide?

@ev-br
Copy link
Member

ev-br commented Apr 17, 2024

This is an interesting fallout :-). Basically, this page should be static. And well discoverable, esp after interp2d starts raising hard errors.
Whether it's back to ReST or link to 1.13 docs --- whichever works.

@j-bowhay j-bowhay added the needs-work Items that are pending response from the author label Apr 19, 2024
@h-vetinari
Copy link
Member Author

Is there an easy way to translate the current website in main to a static RST/MD file, where we don't re-execute the removed import? CC @tupui

@j-bowhay
Copy link
Member

Could we move the offending code cells to be markdown cells with the content surrounded with backticks and then just put the images in?

@tupui
Copy link
Member

tupui commented Apr 29, 2024

Is there an easy way to translate the current website in main to a static RST/MD file, where we don't re-execute the removed import? CC @tupui

I am not sure what you mean. If it's about the API doc itself, I am not sure you can generate it and save it for later builds (besides the normal caching from Sphinx, but I never managed to get this caching working in our CI, I had 2-3 PRs trying various things and gave up. Yes this is 💯 ridiculous that we have to do 20 mins runs for the doc on all PRs 😅😭).

@h-vetinari
Copy link
Member Author

Could we move the offending code cells to be markdown cells with the content surrounded with backticks and then just put the images in?

Wouldn't we have to turn it from a notebook into a regular markdown page? I guess we could save the images from a local run with 1.13 (or main).

I am not sure what you mean.

It might go through many layers, but the end result is a static HTML page. If we can keep showing that webpage, the goal would be achieved; preferably without stripping off too many layers of abstraction.

However I'm tending towards just referring to the 1.13 docs. Those will continue to be a notebook that works fine, and it avoids a large effort for (IMO) questionable gain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated Items related to behavior that has been deprecated needs-work Items that are pending response from the author scipy.interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants