BUG: throw ValueError for mismatched w dimensions and test for error #18199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scb-school
force-pushed
the
17798-w-dimensions-error
branch
from
341cb13
to
11ac339
Compare
scb-school
changed the title
j-bowhay
added
defect
j-bowhay
requested changes
Mar 27, 2023
There was a problem hiding this comment.
Thanks, @scb-school! A couple of suggestions. Also, the lint failure looks related, please could you check (python dev.py lint) and fix this.
tupui
reviewed
Mar 27, 2023
scb-school
force-pushed
the
17798-w-dimensions-error
branch
from
e0ee325
to
7716ad8
Compare
scb-school
requested review from
tupui and
j-bowhay
and removed request for
tylerjereddy,
peterbell10,
tupui and
j-bowhay
j-bowhay
requested changes
Mar 29, 2023
scb-school
force-pushed
the
17798-w-dimensions-error
branch
from
e430c03
to
eb10b52
Compare
j-bowhay
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Thanks @scb-school and congratulations on your first contribution to SciPy, keep them coming!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes #17725
What does this implement/fix?
Fixes misleading error message in hamming function when dimensions of optional argument w do not match u and v. Also implements new test in test_distance.py that checks for the error.
Additional information
N/A